NOT FOR MERGE: getting to to compile with opencilk#1
Open
wheatman wants to merge 1 commit intoPASSIONLab:mainfrom
Open
NOT FOR MERGE: getting to to compile with opencilk#1wheatman wants to merge 1 commit intoPASSIONLab:mainfrom
wheatman wants to merge 1 commit intoPASSIONLab:mainfrom
Conversation
wheatman
force-pushed
the
main
branch
2 times, most recently
from
ead0ea1 to
1f67e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a stab at converting this use opencilk.
It now has some makefile flags which allow you to flip between a serial version, a cilk version, and an openmp version.
I did run into some issues with the code not compiling for what looked to be unrelated reasons like not defining functions, or having includes in the wrong order.
I also didn't have any test files so I could only ensure that the code compiled, not that it ran correctly, but the main base of converting to using modern cilk should be done.