Feature:add new formatters for Tickets#494
Open
andrestejerina97 wants to merge 2 commits intomainfrom
Open
Conversation
andrestejerina97
force-pushed
the
feature/add-ticket-formatters
branch
from
d325475 to
4b7ad9c
Compare
martinquiroga-exo
approved these changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
@andrestejerina97 please review comments. Thanks
martinquiroga-exo
suggested changes
Feb 5, 2026
| ); | ||
|
|
||
| case IAuditStrategy::EVENT_ENTITY_DELETION: | ||
| $quantity_used = ($subject->getQuantityAvailable() ?? 0) - ($quantity_available ?? 0); |
Contributor
There was a problem hiding this comment.
In line 41 we have $quantity_available = $subject->getQuantityAvailable() ?? 0;
This will make $quantity_used always calculate to 0.
Contributor
Author
There was a problem hiding this comment.
Thank you. Please review changes @martinquiroga-exo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b8acw9f