Feature | Extend Swagger Coverage for controller OAuth2SummitSponsorApiController

[andrestejerina97]

ref: https://app.clickup.com/t/86b6wkhd5

[caseylocker]

app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSponsorApiController.php
in 'getSponsorsV2BySummitPublic',
lines 330-336
There is no 'sponsor_id' in the path
Was this a copy paste error that should have gone further down for operationId: 'getSponsorsV2BySummit' which is missing a 'sponsor_id' parameter?
This is documented as a public endpoint - it's mentioned twice.
If that's accurate then remove the Security scopes, Required groups otherwise change the documentation.

In 'getSponsorMaterials'
Line 2070 - IGroup::SponsorExternalUsers,
This isn't included in the seeder. Are we still using the seeder as the source of truth?
This appears again on 2525 in 'getSponsorSocialNetworks'

app/Swagger/Models/SubQuestionRuleSchema.php
line 17
new OA\Property(property: 'answer_values', type: 'string_array'),
'string_array' isn't a valid OpenAPI type.
Should probably be:
new OA\Property(property: 'answer_values', type: 'array', items: new OA\Items(type: 'string')),

The endpoint getSponsorsV2BySummitPublic at /api/public/v1/summits/all/{id}/sponsors is documented as a public endpoint - it's mentioned twice.
If that's accurate then remove the Security scopes, Required groups

[andrestejerina97]

The changes were implemented

[caseylocker]

LGTM

[smarcet]

@andrestejerina97 u are missing all v1 methods defined by the traits please review the routes file

summit-api/routes/api_v1.php

Line 1166 in 315871f

Route::post('', ['middleware' => 'auth.user', 'uses' => 'OAuth2SummitSponsorApiController@add']);

[matiasperrone-exo]

@andrestejerina97 u are missing all v1 methods defined by the traits please review the routes file

summit-api/routes/api_v1.php

Line 1166 in 315871f

Route::post('', ['middleware' => 'auth.user', 'uses' => 'OAuth2SummitSponsorApiController@add']);

Thanks @smarcet for the comments it was a very good catch.
The missing v1 endpoints were incorporated.

Please review again as all the requested changes were incorporated.