Conversation
4500e70 to
567cc68
Compare
caseylocker
requested changes
Dec 4, 2025
caseylocker
left a comment
There was a problem hiding this comment.
Very close.
namespace App\Swagger\Security; should be namespace App\Swagger\schemas;
Should be good after that.
567cc68 to
d2b2d85
Compare
Collaborator
|
@matiasperrone-exo please review conflicts |
caseylocker
reviewed
Dec 10, 2025
caseylocker
left a comment
There was a problem hiding this comment.
Based on the updates, once conflicts are cleared this should be good.
c6ecdd0 to
728ae67
Compare
1aef61b to
d823c38
Compare
caseylocker
requested changes
Dec 18, 2025
caseylocker
left a comment
There was a problem hiding this comment.
It looks like the endpoint for:
#[OA\Post(
path: '/api/v1/summits/{id}/attendees/all/send',
...
Actually uses PUT
Route::put('send', ['middleware' => 'auth.user', 'uses' => 'OAuth2SummitAttendeesApiController@send']);
api_v1.php line 1597
Route::put('send', ...)
ApiEndpointsSeeder.php line 3374:
'http_method' => 'PUT'
Change OA\Post to OA\Put for
#[OA\Post(
path: '/api/v1/summits/{id}/attendees/all/send',
operationId: 'sendAttendeesEmail',
Contributor
Author
|
Thanks @caseylocker for the comments. Now is ready to review again |
0da6489 to
a57f23d
Compare
a57f23d to
ce7918a
Compare
Contributor
Author
|
rebased |
Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
Signed-off-by: Matias Perrone <github@matiasperrone.com>
d44ea3c to
5d507cf
Compare
Signed-off-by: Matias Perrone <github@matiasperrone.com>
bf4077d to
7de9907
Compare
Signed-off-by: Matias Perrone <github@matiasperrone.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b6wkhca
Blocks:
#440