mirror notional payment lag from coupon payment lag#277
Open
Borgomi42 wants to merge 4 commits intoOpenSourceRisk:masterfrom
Open
mirror notional payment lag from coupon payment lag#277Borgomi42 wants to merge 4 commits intoOpenSourceRisk:masterfrom
Borgomi42 wants to merge 4 commits intoOpenSourceRisk:masterfrom
Conversation
added 4 commits
October 25, 2024 16:55
… in case of more than one curve in the same currency
…if notional lag is not given as market standard
mgroncki
reviewed
Apr 3, 2025
| } else { | ||
| std::ostringstream ss; | ||
| ss << MarketDatum::InstrumentType::DISCOUNT << "/" << MarketDatum::QuoteType::RATE << "/" << currency_ << "/*"; | ||
| ss << MarketDatum::InstrumentType::DISCOUNT << "/" << MarketDatum::QuoteType::RATE << "/" << currency_ << "/" << curveConfig_->curveID() << "/*"; |
Contributor
There was a problem hiding this comment.
With the upcoming release we change this, ORE will try to load the quotes as specified if no wildcard is used.
mgroncki
reviewed
Apr 3, 2025
| paymentConvention_ = XMLUtils::getChildValue(node, "PaymentConvention"); | ||
| paymentLag_ = XMLUtils::getChildValue(node, "PaymentLag"); | ||
| notionalPaymentLag_ = XMLUtils::getChildValue(node, "NotionalPaymentLag"); | ||
| notionalPaymentLag_ = XMLUtils::getChildValue(node, "NotionalPaymentLag", false, paymentLag_); |
Contributor
There was a problem hiding this comment.
those are breaking changes, at the moment it defaults to 0 if its not given
Contributor
|
Hi Oleg, thanks for the contribution, it contains a few breaking changes (see my comment above) and it could break existing trades which may rely on the current defaults. Is there a trade where we have a problem with the missing payment calendar? Maybe we can fix it in the trade builder then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally the notional lag in swaps has the same lag as the coupon payment lag. to achieve these result I would propose to put the coupon payment lag as a default value in the notional payment lag. Otherwise one has to list both xml tags which is redundant.