Adopt traffic participant role specification#892
Adopt traffic participant role specification#892thomassedlmayer wants to merge 2 commits intoOpenSimulationInterface:masterfrom
Conversation
d20c45a to
fbb8506
Compare
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
fbb8506 to
c90791b
Compare
There was a problem hiding this comment.
Yes, we should also think about how to include it generically for all moving objects. But I though, we might want to harmonize the existing enum first.
We could just reference the existing enum definition in MovingObjectClassification or - for a cleaner result - move the role enum definition out of the VehicleClassification to be a generic enum definition (osi3::Role instead of osi3::MovingObject::VehicleClassification::Role) and then reference it in two places. I believe this should work in a backwards compatible way because we wouldn't change the data representation by moving enum definitions.
There was a problem hiding this comment.
I can't judge the implications on backwards compatibility of your suggestion for the cleaner result, but it does seem like the better / less confusing approach.

First draft to adopt the traffic participant role specification from https://publications.pages.asam.net/standards/ASAM_TrafficParticipants_Specification/ASAM_TrafficParticipants_Specification/v1.0.0/specification/07_traffic_participants/07_01_general.html