689 add raytracerview config - RAYTRACER_FORMAT#865
Conversation
Reformatted to utilize the ray tracing approach. Offers a generic description, independent of tool provider or sensor technology Signed-off-by: SandroReith <40294694+SandroReith@users.noreply.github.com>
updated enum for RAYTRACER_FORMAT_SBR 3 -> 2 Signed-off-by: SandroReith <40294694+SandroReith@users.noreply.github.com>
thomassedlmayer
left a comment
thomassedlmayer
left a comment
There was a problem hiding this comment.
@SandroReith: Maybe we could already merge this PR into the other PR (#699) and continue working there?
Another topic: Since this is about the unambiguous specification of a binary format, isn't it necessary to also specify the float size/precision. endianness and vector/matrix value order?
| // direction_of_departure_hitpoint (float3; in m; coordinates of the DoD (first hitpoint) in the raytracer's coordinate system defined by the mounting position) | ||
| // | ||
| RAYTRACER_FORMAT_VIVALDI_RADAR = 3; | ||
| RAYTRACER_FORMAT_SBR = 2; |
There was a problem hiding this comment.
Sensor Modeling Group (11.06.): Discussion about additional format type including the field "bounce depth" -> Add it only as additional/optional pull request. @SandroReith Do you want this other format to be included as well? What would be a good name for it?
| // direction_of_departure_azimuth (float; in rad; direction of departure of the ray in the configured raytracer coordinate system in azimuth direction) | ||
| // direction_of_departure_elevation (float; in rad; direction of departure of the ray in the configured raytracer coordinate system in elevation direction) | ||
| // | ||
| RAYTRACER_FORMAT_DIVP_RADAR = 2; |
There was a problem hiding this comment.
Sensor Modeling Group (11.06.): Agree to remove DIVP type for now. Inclusion of the DIVP format depends on someone involved in the DIVP project and working with this format.
|
@SandroReith @thomassedlmayer Could we merge this PR? |
thomassedlmayer
merged commit 7f7476c
into
OpenSimulationInterface:689-add_raytracerview_config
3 participants
Issue #699
Add a description
Reformatted to utilize the ray tracing approach
Offers a generic description, independent of tool provider or sensor technology
Some questions to ask:
What is this change?
Format of the Raytracing View.
Content of the Raytracing View
Name of the enum
What does it fix?
Reduces dependency on specific tools and technologies
Facilitates standardization and unification
How has it been tested?
proposal