Make intersection free lane boundary definition more concrete#827
Open
FabianPfeuffer wants to merge 2 commits intoOpenSimulationInterface:masterfrom
Open
Make intersection free lane boundary definition more concrete#827FabianPfeuffer wants to merge 2 commits intoOpenSimulationInterface:masterfrom
FabianPfeuffer wants to merge 2 commits intoOpenSimulationInterface:masterfrom
Conversation
Signed-off-by: Fabian Pfeuffer <Fabian.Pfeuffer@bmw.de>
Member
|
@thomassedlmayer could you please discuss this in the sensor modeling project meeting? |
Contributor
|
@tbleher you might also have an opinion on whether this is a correct/useful clarification. |
| // \note \c Lane with \c #type = \c #TYPE_INTERSECTION use only free | ||
| // lane boundaries. | ||
| // | ||
| // \note Free boundaries should be defined in clockwise direction. The starting |
Contributor
There was a problem hiding this comment.
Is this only about the definition order of the boundary points or also about the order of referencing free lane boundaries in the list (e.g. [11, 14, 13, 12]?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a description
This pull request makes the definition of free boundaries for lanes more concrete.
It suggests that the free boundaries of an intersection lane should follow a general definition direction (in this case clockwise)
Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board: