Remove is_globally_unique rule from messages, where it does not make sense

[ClemensLinnhoff]

Reference to a related issue in the repository

#809

Add a description

Removed rule is_globally_unique from messages, where a globally unique ID does not make any sense.

Some IDs depend on the scenario, e.g. object IDs in Ground Truth. Some IDs depend on the map, e.g. lane IDs. And some IDs depend on the sensor setup, e.g. sensor IDs.

I can't think of a reason, why there shouldn't be a moving object with ID 0, a lane with ID 0 and a sensor with ID 0. Therefore, I removed the is_globally_unique rule from every message, that is not a ground truth object.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

• My suggestion follows the style and contributors guidelines.
• I have taken care about the message documentation and the fields and enums documentation.
• I have done the DCO signoff.
• My changes generate no errors when passing CI tests.
• I have successfully implemented and tested my fix/feature locally.
• Appropriate reviewer(s) are assigned.

[pmai]

See comments, these seem overbroad in some places.

In any case I think just removing the rules and statements, meaning that the uniqueness is now completely undefined seems like the wrong way to go about it. I'd rather refine the definition of globally unique to clarify that cross-type uniqueness is only meant for the groundtruth objects, leaving globally unique to still mean unique across simulation time.
How to handle this the best in terms of the rule names is another question.

[yash-shah-asam]

@pmai Could you please discuss this with the OSI Checker bundle group?