Add tunnel, barrel, guide post types (AUTOSAR ADI/ISO23150)#661
Open
FlorianMueller87 wants to merge 4 commits intoOpenSimulationInterface:masterfrom
Conversation
d31a300 to
397ad4c
Compare
Signed-off-by: Stefan Cyliax <stefan.cyliax@asam.net>
397ad4c to
f222f40
Compare
Signed-off-by: Stefan Cyliax <stefan.cyliax@asam.net>
New elements: BARREL, GUIDE_POST, TUNNEL Issue: OpenSimulationInterface#641 Signed-off-by: FlorianMueller87 <florian.b.mueller@gmx.de>
Issue: OpenSimulationInterface#641 Signed-off-by: FlorianMueller87 <florian.b.mueller@gmx.de>
f222f40 to
4be3d75
Compare
Contributor
|
Comments:
TODO:
|
Member
|
@thomassedlmayer could you please take a look at it in 23150 project group? |
Contributor
|
In my opinion a guide post would currently be categorized as delineator. At least multiple translation websites translate "Leitpfosten" to "delineator" AND "guide post": The bigger problem could be to define the differentation between reflective structure and delineator. If a barrel should represent something like in the following picture, it would probably be of type delineator (or reflective structure). @FlorianMueller87 Could you give some feedback on this from AUTOSAR ADI perspective soon? Otherwise we will probably close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reference to a related issue in the repository
#641
Add a description
ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.
ASAM OSI need the entries for osi_objects – StationaryObject – Classification - Type to be compatible with AUTOSAR ADI GeneralLandmarkClassificationType.
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
Additional context
ISO23150:2021 A.2.105 General landmark classification type
@ThomasNaderBMW @jdsika @schmidtlorenz