Add new lane boundary classification type (fence, tension cable system)#658
Open
FlorianMueller87 wants to merge 6 commits intoOpenSimulationInterface:masterfrom
Conversation
FlorianMueller87
changed the title
Issue: OpenSimulationInterface#643 Signed-off-by: FlorianMueller87 <florian.b.mueller@gmx.de>
…E and STRONGEST Issue: OpenSimulationInterface#643 Signed-off-by: FlorianMueller87 <florian.b.mueller@gmx.de>
… TENSION_CABLE_SYSTEM Issue: OpenSimulationInterface#642 Signed-off-by: FlorianMueller87 <florian.b.mueller@gmx.de>
FlorianMueller87
force-pushed
the
feature/add_elements_to_LaneBoundary_Classification_Type
branch
from
23fd02a to
7088b2c
Compare
jdsika
added
the
Harmonisation
jdsika
reviewed
Oct 17, 2022
jdsika
reviewed
Oct 17, 2022
|
|
||
| // The lane boundary is a fence. | ||
| // | ||
| TYPE_FENCE = 16; |
Contributor
There was a problem hiding this comment.
A FENCE could be described with STRUCTURE?
Contributor
Author
There was a problem hiding this comment.
At the moment we have mapped STRUCTUR to WALL.
jdsika
reviewed
Oct 17, 2022
|
|
||
| // The lane boundary is a tension cable system. | ||
| // | ||
| TYPE_TENSION_CABLE_SYSTEM = 17; |
Contributor
There was a problem hiding this comment.
This would be the same as a GUARD_RAIL but constructed differently?
Contributor
Author
There was a problem hiding this comment.
It looks something like this: https://gibraltarglobal.com/
Contributor
|
@FlorianMueller87
|
thomassedlmayer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
#642
Add a description
ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.
ASAM OSI need the entries for osi_lane – LaneBoundary – Classification - Type to be compatible with AUTOSAR ADI RoadBoundaryType.?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
Describe alternatives you have considered
No alternative was considered.
Describe the backwards compatibility
The adding of the elements will not lead to backward compatibility issues.
Additional context
ISO23150:2021 A.2.102 Road boundary type