Open
Conversation
eroux
requested changes
Jan 3, 2023
Contributor
eroux
left a comment
eroux
left a comment
There was a problem hiding this comment.
please document a bit more
| bdrc_id: str | ||
| location_info: dict | ||
| diplomatic_id:Optional[List[str]] | ||
| alignmnet_ids:Optional[List[str]] |
| colophon: str | ||
| authors: List[str] | ||
| bdrc_id: str | ||
| location_info: dict |
Contributor
Author
Contributor
There was a problem hiding this comment.
ok, but that's not really how it should work: the design of the metadata in OpenPecha shouldn't be driven by some query I made quickly a few months ago, there should be some proper design effort to create good OpenPecha metadata, document it and then build a query to get this data from BDRC
| language: str | ||
| bdrc_work_id: str | ||
| authors: List[str] | ||
| best_instance:Optional[InstanceMetadata] |
Contributor
There was a problem hiding this comment.
shouldn't that be best_instance_id: str instead?
| alignment_to_base:Dict[str,str] | ||
| source_metadata: Optional[Dict] = None | ||
|
|
||
| class InstanceMetadata(BaseModel): |
Contributor
There was a problem hiding this comment.
can you document a little bit what an instance, an alignment, a work and a collection are? My intuition is that instances should not have authors but should instead have works, but since it's all a bit unclear I'm not sure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey,I have update the openpecha.core.metadata with the work metadata,instance metadata and alignment metadata.