Conversation
|
I think I would not bother updating the driver for simplesender. I didn't even realize what that code did until I looked at it. It hasn't been touched in 13 years. That library was added 18 years ago. My best guess is that it was part of some undocumented test process. I don't believe it was included in the mirth distributions, and it doesn't look like it even gets built as part of the normal build process. We probably need to evaluate to see if we want to get rid of it, and if we decide to keep it with the existing postgres functionality, it should be using a modern driver. |
jonbartels
left a comment
There was a problem hiding this comment.
Do not update the JARS in simplesender. They are not packaged in the OIE server or client.
|
@tonygermano - I agree with you. I filed #88 |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Ignore me asking CoPilot to review please. |
5c39642 to
2256d9f
Compare
39ac634
39ac634 to
5bde40d
Compare
|
@jonbartels is picking this up again - We've likely let it sit so long the PG drivers are outdated. It definitely needs a rebase against main |
I actually just rebased it less than 12 hours before you did, but the drivers are definitely outdated. |
Signed-off-by: Richard Ogin <rogin@users.noreply.github.com>
Signed-off-by: Tony Germano <tony@germano.name>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
5bde40d to
1ebc434
Compare
There was a problem hiding this comment.
I rebased to main, took the latest pg jars from maven central.
I tested by merging a docker build from #101 and using the below compose file:
version: "3.1"
services:
mc:
image: oie-dev
environment:
- DATABASE=postgres
- DATABASE_URL=jdbc:postgresql://db:5432/mirthdb
- DATABASE_MAX_CONNECTIONS=20
- DATABASE_USERNAME=mirthdb
- DATABASE_PASSWORD=mirthdb
- KEYSTORE_STOREPASS=docker_storepass
- KEYSTORE_KEYPASS=docker_keypass
- VMOPTIONS=-Xmx512m
volumes:
- ./data/volumes/appdata:/opt/connect/appdata
ports:
- 8080:8080/tcp
- 8443:8443/tcp
depends_on:
- db
db:
image: postgres
environment:
- POSTGRES_USER=mirthdb
- POSTGRES_PASSWORD=mirthdb
- POSTGRES_DB=mirthdb
expose:
- 5432built with docker build -t oie-dev ., started with docker-compose -f oie-pg.yml up and tested basic functionality (login, set password, create channel, deploy, send message, list results)
Issue #78
Pulled latest v42.6.x from here. SHA1 hash verified. Sonatype showed it having zero vulnerabilities.
Could not find other PG jar at version "-405". Pulled latest "-408" version here. 2007 timestamp. SHA1 hash verified.
Code compiled w/exception of KeyEncryptorTest, which I deleted. All failed tests ignored.
Ignore the tool listing two renames - two files were deleted, and two files were added.