Fix warnings about deprecated constructors#148
Fix warnings about deprecated constructors#148kpalang merged 2 commits intoOpenIntegrationEngine:mainfrom
Conversation
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
tonygermano
left a comment
There was a problem hiding this comment.
I made several comments related to the auto-boxing commit. In general, where auto-boxing of primitives without casting is not enough, I would prefer to see the PrimitiveWrapper.valueOf() methods used over a cast. There are a few places where you have done it that way, and others where you have not.
I don't think we should make the security manager changes at this time. The security manager still works through java 23. According to https://openjdk.org/jeps/486, from java 24 on, it behaves as if a security manager is not installed, but the api methods have not yet been removed. Since we don't know who is currently using a security manager, I think we should not remove support for it without adequate warning. Obviously, if we eventually drop support for java versions < 24 there is no reason to keep it.
donkey/src/main/java/com/mirth/connect/donkey/server/data/buffered/BufferedDao.java
Outdated
Show resolved
Hide resolved
server/src/com/mirth/connect/server/controllers/DonkeyEngineController.java
Outdated
Show resolved
Hide resolved
client/src/com/mirth/connect/client/ui/browsers/message/MessageBrowser.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
c038359 to
956c284
Compare
|
I split #152 out to separately address java security manager. |
tonygermano
left a comment
There was a problem hiding this comment.
Thanks. Changes all look good to me.
jonbartels
left a comment
There was a problem hiding this comment.
Is there a specific testing process we can use to observe these build warnings?
Just build it and read the output or is there a better way to filter through all the noise that ant spews out?
|
@jonbartels, I'm just reading ant output. Once we get to zero (by fixing or if a warning is intractable by adding a suppression), I'd recommend turning on "warnings as errors" in the GitHub Action to avoid introducing new warnings in PRs. This also will make warnings introduced by version changes obvious (e.g. dependabot). |
Fixes javac build warnings present on Java 8 and Java 17.