Closed
Conversation
Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
kpalang
requested review from
a team,
gibson9583,
jonbartels,
kayyagari and
tonygermano
and removed request for
a team
kayyagari
approved these changes
Jul 3, 2025
jonbartels
approved these changes
Jul 3, 2025
Contributor
|
Notes on testing. To test this we need to review:
|
tonygermano
reviewed
Jul 9, 2025
Member
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
See comments here #1 (comment).
I haven't tried to build this myself, but I have a feeling the useradd on the ubuntu image is going to fail since uid 1000 already exists.
Contributor
Author
|
I think this PR is superseded by #4. I've made some improvements there on how the image should be built. |
Contributor
Contributor
Author
|
Closing as this PR is superseded by #4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to setting the user and group id-s to 1000, the PR makes pushes to main deploy the image to Docker Hub. Also removed the ability to manually trigger the workflow.
The deploy currently runs on all pushes to main. This is intended as a intermediate solution until the next hotness arrives.