fix: enhance event loop management and update dependencies #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Resolved merge conflicts in client.py and updated the asyncio loop management logic to support nested loops. |
- Added missing scheme_filter parameter to X402Auth.__init__ - Updated async_auth_flow to use scheme_filter in payment requirements selection - Fixed type hinting for payment_requirements_selector to resolve Copilot warnings
Author
|
Synced this PR with the latest changes in main. I've applied the asyncio loop management fix to the new AsyncClient structure and updated the X402Auth call to include the new scheme_filter for consistency across the SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the stability of the Python SDK by addressing event loop conflicts and refining exception handling.
Key Changes:
asyncio.run()with a more robust logic usingget_event_loopandnest_asyncio. This fixes crashes when the SDK is used inside existing async frameworks (like FastAPI or Jupyter).except:block in_is_local_modelto catch only specific exceptions (AttributeError,TypeError,ValueError).nest-asyncioto the project dependencies to support the new event loop logic.Testing:
Verified that the client no longer raises
RuntimeErrorwhen called from an active event loop.