Open
Conversation
pinebit
force-pushed
the
pinebit/threshold-validation
branch
from
cb0b9d8 to
1656296
Compare
KaloyanTanev
reviewed
Feb 2, 2026
Comment on lines
56
to
59
| threshold := config.Threshold | ||
| if threshold == 0 { | ||
| threshold = cluster.Threshold(len(nodes)) | ||
| } |
Collaborator
There was a problem hiding this comment.
Is this a plausible scenario if this is called from the CLI? If the default is 0, can we add a debug log here?
Can a user set a negative number? It might be worth it making it a uint?
Collaborator
Author
There was a problem hiding this comment.
Improved this in the new iteration. Thank you for the feedback!
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4268 +/- ##
==========================================
+ Coverage 56.64% 56.66% +0.02%
==========================================
Files 237 237
Lines 31332 31362 +30
==========================================
+ Hits 17748 17772 +24
- Misses 11311 11319 +8
+ Partials 2273 2271 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added threshold validation for
RunDKGandRunReshareDKG. Previous behavior delegated the check down the stack to allow underlying library (kyber) to validate the threshold. Given that Kyber has weak validation that can lead to weird late errors, it is more convenient to verify the threshold upfront.Additionally added verification such that users cannot remove all nodes with "remove operators" command.
category: refactor
ticket: none