Fix: the reserved bits in the Mode field of m/stvec#154
Open
youzi27 wants to merge 1 commit intoOSCPU:masterfrom
Open
Fix: the reserved bits in the Mode field of m/stvec#154youzi27 wants to merge 1 commit intoOSCPU:masterfrom
youzi27 wants to merge 1 commit intoOSCPU:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #153
Explanation: When setting the value of the MODE field, the reserved bit (bit 1) should be cleared to zero. When reading the BASE field, the lowest bit (bit 0) of the MODE segment should be cleared to zero. This approach prevents writing to undefined MODE values and also ensures that the BASE field is four-byte aligned. Previously, neither of these requirements was satisfied.