Open
Conversation
wakafa1
reviewed
Nov 7, 2022
| @@ -0,0 +1,6 @@ | |||
| #FileLock | |||
Contributor
There was a problem hiding this comment.
看起来 .metals 中的文件在修改 gitignore 之前被仓库跟踪了?
Author
There was a problem hiding this comment.
oops,我只是删除了本地的但没有revert回去,我改一下再push
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
当前版本中包含了几类修改:
文件切分与移动:
受到影响的文件:
/src/main/scala/nutcore/frontend/*
/src/main/scala/nutcore/backend/ooo/Backend.scala
/src/main/scala/nutcore/mem/*
文件/目录/部分模块的命名及重命名
受到影响的文件仅包括被切分和移动的文件
改写namespace
原先
nutcore部分中所有的文件都在同一个namespace即nutcore下,此版本经改动后,文件的namespace按照scala的命名规范与其目录结构一致。受到影响的文件包括被切分和移动的文件,以及引用了这些文件内代码的文件
暂时移除所有
sealed关键字由于注为
sealed的class及trait不能跨文件引用,因在重构过程中仍会有文件的创建/切分/移动的可能,故暂时移除所有sealed关键字,待代码结构稳定后视情况补齐。未被切分和移动的文件,以及被切分和移动文件所包含的模块内部在此次提交中均未受改动