Skip to content

TEDEFO-4319 Add privacy settings and data types#44

Merged
bertrand-lorentz merged 1 commit intodevelopfrom
TEDEFO-4319-privacy-settings-in-efx
Feb 9, 2026
Merged

TEDEFO-4319 Add privacy settings and data types#44
bertrand-lorentz merged 1 commit intodevelopfrom
TEDEFO-4319-privacy-settings-in-efx

Conversation

@rousso
Copy link
Contributor

@rousso rousso commented Feb 8, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds privacy-related metadata to SDK fields and introduces a preliminary (hardcoded) SDK data-type repository to support privacy masking behavior across types.

Changes:

  • Extend SdkField with privacy metadata (privacyCode) and PrivacySettings (including field-id references).
  • Update SdkFieldRepository to perform a second pass resolving PrivacySettings field references after all fields are loaded.
  • Add SdkDataType and SdkDataTypeRepository (hardcoded defaults) to represent type-level privacy masking metadata.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/main/java/eu/europa/ted/eforms/sdk/repository/SdkFieldRepository.java Adds a second-pass step to resolve privacy-related field references.
src/main/java/eu/europa/ted/eforms/sdk/repository/SdkDataTypeRepository.java Introduces a hardcoded repository of data types with privacy masks (temporary until JSON exists).
src/main/java/eu/europa/ted/eforms/sdk/entity/SdkField.java Adds privacy parsing and a PrivacySettings structure to fields.
src/main/java/eu/europa/ted/eforms/sdk/entity/SdkDataType.java New entity capturing data-type ID and privacy mask.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bertrand-lorentz bertrand-lorentz merged commit 3462dc2 into develop Feb 9, 2026
11 checks passed
@bertrand-lorentz bertrand-lorentz deleted the TEDEFO-4319-privacy-settings-in-efx branch February 9, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants