TEDEFO-4319 Add privacy settings and data types#44
Merged
bertrand-lorentz merged 1 commit intodevelopfrom Feb 9, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds privacy-related metadata to SDK fields and introduces a preliminary (hardcoded) SDK data-type repository to support privacy masking behavior across types.
Changes:
- Extend
SdkFieldwith privacy metadata (privacyCode) andPrivacySettings(including field-id references). - Update
SdkFieldRepositoryto perform a second pass resolvingPrivacySettingsfield references after all fields are loaded. - Add
SdkDataTypeandSdkDataTypeRepository(hardcoded defaults) to represent type-level privacy masking metadata.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/main/java/eu/europa/ted/eforms/sdk/repository/SdkFieldRepository.java |
Adds a second-pass step to resolve privacy-related field references. |
src/main/java/eu/europa/ted/eforms/sdk/repository/SdkDataTypeRepository.java |
Introduces a hardcoded repository of data types with privacy masks (temporary until JSON exists). |
src/main/java/eu/europa/ted/eforms/sdk/entity/SdkField.java |
Adds privacy parsing and a PrivacySettings structure to fields. |
src/main/java/eu/europa/ted/eforms/sdk/entity/SdkDataType.java |
New entity capturing data-type ID and privacy mask. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/eu/europa/ted/eforms/sdk/repository/SdkFieldRepository.java
Show resolved
Hide resolved
bertrand-lorentz
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.