Open
Conversation
Owner
|
The close packet with id 0 was not intentional. I've fixed this in 33f4d37, but let me know if there's still any issues with this / if this PR is still needed. |
Author
|
I'm a bit busy until New Years, I'll let you know by then/a bit after |
|
I beleive this field has no reason |
Owner
No, exposing implementation details for no reason is bad API design. Also, as far as I know Bukkit doesn't expose container ids anywhere either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publicize the container id of a Window to primarily allow properly closing menus on the Bedrock Platform.
Bedrock has an issue where you cannot close a InvUI Packet Container because the Bukkit
Player#closeInventorymethod cannot close the menu without a proper container id being specified, the only way to resolve this is to manually send the close container packet yourself with the container id attached so Bedrock Clients can properly close InvUI Menus