[Perf] Update labelGPUNodes() to reset updateLabels inside loop#2113
Open
smalleni wants to merge 1 commit intoNVIDIA:mainfrom
Open
[Perf] Update labelGPUNodes() to reset updateLabels inside loop#2113smalleni wants to merge 1 commit intoNVIDIA:mainfrom
smalleni wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
As a golden rule of performance, we should never do work that is not necessary. In the current implementation where updateLabels is declared outside the for loop, if updateLabels becomes true for the first node in a large GPU cluster, it triggers a PATCH request to the API for every subsequent node even when not necessary. This maybe a cheap call but we should never do work that is not necessary. Moving updateLabels inside of the for loop, reduces APi calls and load, along with improving reconcilliation time. Signed-off-by: Sai Sindhur Malleni <smalleni@nvidia.com>
smalleni
requested review from
ArangoGutierrez,
cdesiniotis,
karthikvetrivel,
shivamerla and
tariq1890
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a golden rule of performance, we should never do work that is not necessary. In the current implementation where updateLabels is declared outside the for loop, if updateLabels becomes true for the first node in a large GPU cluster, it triggers a PATCH request to the API for every subsequent node even when not necessary. This maybe a cheap call but we should never do work that is not necessary. Moving updateLabels inside of the for loop, reduces APi calls and load, along with improving reconcilliation time.
Description
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing