Skip to content

Faster enum implementation #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mdboom wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Faster enum implementation #1569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a7e249e
Faster enum implementation
mdboom Feb 3, 2026
b60b0ad
Fix setup.py
mdboom Feb 3, 2026
8beb687
Fix one test
mdboom Feb 3, 2026
677a7e8
Fix reference leak
mdboom Feb 3, 2026
32a872d
Fix bug
mdboom Feb 3, 2026
5bd0555
Fix tests
mdboom Feb 3, 2026
471b529
Fix more versions of Python
mdboom Feb 3, 2026
6cbea13
Fix for older Pythons
mdboom Feb 3, 2026
0bc11d6
Apply suggestions from code review
mdboom Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cuda_bindings/cuda/bindings/_lib/utils.pxi.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# SPDX-FileCopyrightText: Copyright (c) 2021-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-FileCopyrightText: Copyright (c) 2021-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: LicenseRef-NVIDIA-SOFTWARE-LICENSE

from cpython.buffer cimport PyObject_CheckBuffer, PyObject_GetBuffer, PyBuffer_Release, PyBUF_SIMPLE, PyBUF_ANY_CONTIGUOUS
from libc.stdlib cimport calloc, free
from libc.stdint cimport int32_t, uint32_t, int64_t, uint64_t
from libc.stddef cimport wchar_t
from libc.string cimport memcpy
from enum import Enum as _Enum
from cuda.bindings.utils._fast_enum import _FastEnum
import ctypes as _ctypes
cimport cuda.bindings.cydriver as cydriver
cimport cuda.bindings._lib.param_packer as param_packer
Expand Down Expand Up @@ -73,7 +73,7 @@ cdef class _HelperKernelParams:
self._ckernelParams[idx] = <void*><void_ptr>value.getPtr()
elif isinstance(value, (_ctypes.Structure)):
self._ckernelParams[idx] = <void*><void_ptr>_ctypes.addressof(value)
elif isinstance(value, (_Enum)):
elif isinstance(value, (_FastEnum)):
self._ckernelParams[idx] = &(self._ckernelParamsData[data_idx])
(<int*>self._ckernelParams[idx])[0] = value.value
data_idx += sizeof(int)
Expand Down
Loading