Fix to use resident device stream in IPC peer access tests#1568
Closed
rwgk wants to merge 1 commit intoNVIDIA:mainfrom
Closed
Fix to use resident device stream in IPC peer access tests#1568rwgk wants to merge 1 commit intoNVIDIA:mainfrom
rwgk wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
|
kkraus14
reviewed
Feb 4, 2026
| # Test 1: Buffer accessible from resident device (dev1) - should always work | ||
| dev1 = Device(1) | ||
| dev1.set_current() | ||
| dev1_stream = dev1.create_stream() |
Collaborator
There was a problem hiding this comment.
This stream is used for test2, can we move the creation underneath the test 2 comment?
| dev1 = Device(1) | ||
| dev1.set_current() | ||
| dev1_stream = dev1.create_stream() | ||
| PatternGen(dev1, NBYTES).verify_buffer(buffer, seed=False) |
Collaborator
There was a problem hiding this comment.
Just a note that PatternGen uses unified / managed memory underneath it where I suspect this may give us some pain / troubles on Windows?
Collaborator
Author
github-actions bot
pushed a commit
that referenced
this pull request
Feb 5, 2026
Removed preview folders for the following PRs: - PR #1568
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This resolves failures in QA environments (nvbug 5821337; internal PR 242).