Add a note about building containers manually#793
Open
nv-alaiacano wants to merge 5 commits intomainfrom
Open
Conversation
nv-alaiacano
requested review from
jperez999,
karlhigley,
mikemckiernan and
rnyak
Contributor
Author
|
note: tests do not need to run on this documentation-only PR so I canceled the compute-heavy ones. |
Documentation preview |
rnyak
reviewed
Jan 17, 2023
docker/README.md
Outdated
|
|
||
| ## Default Arguments | ||
|
|
||
| Each of the Dockerfiles have many `ARG`s defined, most of which have defaults set. Sometimes the defaults fall out of date, because the Merlin team overrides them in our build process as demonstrated above. To see the latest versions used in each of our containers, see the [Merlin Support Matrix](https://nvidia-merlin.github.io/Merlin/main/support_matrix/index.html) |
Contributor
There was a problem hiding this comment.
may be rephrase to see the latest versions as to see the latest release versions ?
mikemckiernan
approved these changes
Jan 17, 2023
Member
mikemckiernan
left a comment
mikemckiernan
left a comment
There was a problem hiding this comment.
Hopefully, you find something helpful in there. Let me know what I can clarify.
jperez999
requested changes
Jan 18, 2023
Collaborator
jperez999
left a comment
jperez999
left a comment
There was a problem hiding this comment.
Other than the incorrect --build-arg assignment it looks good. Thanks for putting this together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per some customer questions, we can add a guide for building the containers from the provided Dockerfiles.
I'm building now using the commands I used in the README and will validate that they work. Feedback on terminology or accuracy of the build stages is appreciated.