Open
Conversation
Luis729
requested changes
Mar 13, 2020
Member
|
when u do just a small OCD thing of mine |
Luis729
requested changes
Mar 13, 2020
rSchwartz1
force-pushed
the
twoGeoBoxes
branch
2 times, most recently
from
bae005c to
776fe53
Compare
Luis729
requested changes
Mar 17, 2020
Member
|
Can we link #113 to this? This PR closes this issue |
Member
|
Update, this PR will not close #113, that's a different issue |
rSchwartz1
force-pushed
the
twoGeoBoxes
branch
2 times, most recently
from
8fcb835 to
25972b5
Compare
Luis729
requested changes
Mar 18, 2020
## Why is this being changed? This is being changed because of Northrop's requirement of having a KeepIn and KeepOut box for all vehicles. The KeepIn area is an area that all vehicles must stay inside of, and will be about the size of the mission field/runway. The KeepOut area is an area that all vehicles must stay outside of, and will be the location of all student/Northrop observers. ## What was changed to address this problem? In order to address the problem, two geofence buttons were created inside of the missionWindow UI tah tallows the GCS operator to dynamically create the two boxes individually, separating them by color. ## How was this change tested? This change was tested with npm test.
Luis729
requested changes
Mar 19, 2020
| export type Message = StartMessage | AddMissionMessage | PauseMessage | ResumeMessage | StopMessage | ||
| | GeofenceMessage | ConnectionAckMessage | UpdateMessage | POIMessage | CompleteMessage | ||
| | ConnectMessage | AcknowledgementMessage | BadMessage; | ||
| /** |
Member
There was a problem hiding this comment.
my bad, lets put the extra line back between line 292 and 293, and remove the unnecessary line in 289
| /** | ||
| * geofence.keepOut and geofence.keepIn are defined as an array of tuples( [[number, number]] ). | ||
| * Each tuple consists of [ [latitude, longitude] ]. | ||
| */ |
Member
There was a problem hiding this comment.
lets change the description to something like this Array of tuples that represent [latitude, longitude], and put
the description on top of keepOut and keepIn. message me if you need more clarification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this being changed?
This is being changed because of Northrop's requirement of having a
KeepIn and KeepOut box for all vehicles. The KeepIn area is an area that
all vehicles must stay inside of, and will be about the size of the
mission field/runway. The KeepOut area is an area that all vehicles must
stay outside of, and will be the location of all student/Northrop
observers.
What was changed to address this problem?
In order to address the problem, two geofence buttons were created
inside of the missionWindow UI tah tallows the GCS operator to
dynamically create the two boxes individually, separating them by
color.
How was this change tested?
This change was tested with npm test.