Replace the "[version]" in the body of the markdown, fix #37#39
Merged
dead-claudia merged 1 commit intoMithrilJS:mainfrom Oct 2, 2025
Merged
Replace the "[version]" in the body of the markdown, fix #37#39dead-claudia merged 1 commit intoMithrilJS:mainfrom
dead-claudia merged 1 commit intoMithrilJS:mainfrom
Conversation
The "[]" in the link will be encoded, so "[version]" must be replaced before marked conversion.
dead-claudia
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the flems link to provide the current mithril version.
Description
The
[version]added in 3811498 does not appear to have been converted to the version.The existing replacement processing for the version does not seem to apply to the markdown body.
Also, the "[]" in the link will be encoded, so "[version]" must be replaced before marked conversion.
Motivation and Context
Fix #37