Add restrictions in cmd start and stop vote#23
Open
Nord1cWarr1or wants to merge 6 commits intoMistrick:masterfrom
Open
Add restrictions in cmd start and stop vote#23Nord1cWarr1or wants to merge 6 commits intoMistrick:masterfrom
Nord1cWarr1or wants to merge 6 commits intoMistrick:masterfrom
Conversation
Contributor
Author
|
@Mistrick how do you think, maybe add a console message for player? |
Mistrick
requested changes
Nov 12, 2022
| } | ||
| public concmd_stopvote(id, level, cid) | ||
| { | ||
| if(is_vote_finished()) { |
Owner
There was a problem hiding this comment.
is_vote_finished() -> !is_vote_started()
| } | ||
| public concmd_startvote(id, level, cid) | ||
| { | ||
| if(is_vote_started() || is_vote_finished() || is_vote_will_in_next_round()) { |
Owner
There was a problem hiding this comment.
Вынеси is_vote_started() в отдельное условие.
Для is_vote_finished() || is_vote_will_in_next_round() добавь квар.
Contributor
Author
There was a problem hiding this comment.
Что должен делать квар?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to add restrictions in cmd start and stop vote. Now they can cause bugs.
For example: the voting is starts in new round. If now make
mapm_stop_vote, thenmp_timelimitwill stay "0"