core_complex: set NONE finish condition#42
Draft
eugenecohen-qti wants to merge 1 commit intoMinres:mainfrom
Draft
core_complex: set NONE finish condition#42eugenecohen-qti wants to merge 1 commit intoMinres:mainfrom
eugenecohen-qti wants to merge 1 commit intoMinres:mainfrom
Conversation
Contributor
|
Using a cci_param is my preferred solution for this. Implementing a converter would even allow to specify them literally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@eyck we need some way to specify a finish condition of NONE. This PR is just a brute-force solution which I presume doesn't work for all use cases. What would you like to do here? We could define a CCI variable (or multiple) if that would be better.