Refactoring MiniProfilerBaseOptionsExtensions.ExpireAndGetUnviewedAsync#617
Open
profet23 wants to merge 5 commits intoMiniProfiler:mainfrom
Open
Refactoring MiniProfilerBaseOptionsExtensions.ExpireAndGetUnviewedAsync#617profet23 wants to merge 5 commits intoMiniProfiler:mainfrom
profet23 wants to merge 5 commits intoMiniProfiler:mainfrom
Conversation
…nc to utilize a new overload of IAsyncStorage.SetViewedAsync that accepts multiple ids. Adding PostgreSqlStorage implementation that can set multiple profilers as viewed in a single query.
Member
|
For this to happen, it'll need to wait for a 5.x release due to breaking a primary interface here for current implementers. I'll take a peek and surface looks sound, but it is breaking so want to give an early heads up on timing expectations. |
Author
It should be backwards compatible. I don't believe there are any breaking changes. Ah nevermind, you were talking about third party implementers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring
MiniProfilerBaseOptionsExtensions.ExpireAndGetUnviewedAsyncto utilize a new overload ofIAsyncStorage.SetViewedAsyncthat accepts multiple ids.Adding
PostgreSqlStorageimplementation that can set multiple profilers as viewed in a single query.This query is called a lot, so trying to reduce database round trips.