Align banner and step headers with ANSI/emoji-aware padding#7
Closed
JordiPosthumus wants to merge 4 commits intoMiniMax-AI:mainfrom
Closed
Align banner and step
headers with ANSI/emoji-aware padding#7JordiPosthumus wants to merge 4 commits intoMiniMax-AI:mainfrom
JordiPosthumus wants to merge 4 commits intoMiniMax-AI:mainfrom
Conversation
- Add provider to config + CLI
- Implement chat/completions path with tool schema conversion
- Update README + config example for LM Studio
- Preserve Anthropic (MiniMax) default
…hinking
- Explain LM Studio setting for reasoning_content
- Note <think>…</think> fallback extraction
- Clarify Anthropic-style interleaved thinking for MiniMax M2
- Extract BaseLLM and provider classes (AnthropicLLM, OpenAILLM) - LLMClient becomes a thin facade that selects provider - OpenAI path: parse reasoning_content and <think> fallback - Convert tools to OpenAI schema; parse tool_calls - docs: LM Studio reasoning + interleaved thinking notes - tests: add OpenAI provider unit tests (no network)
- Use visible column width (emoji/EAW) and safe ellipsis
Collaborator
|
Hi @JordiPosthumus, Thank you for this excellent PR! You correctly identified the Unicode alignment issue and provided a solid solution using We've implemented a similar fix based on your approach, with some additional improvements:
Your work directly inspired this solution. While we won't merge the PR as-is, your contribution was instrumental in improving Mini-Agent's terminal UI. All boxes now align perfectly! 🎉 We appreciate your contribution and look forward to more from you! Best regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui(cli): fix misaligned borders and overflow by computing visible column width
(emoji/EAW aware) and safe ellipsis. Applied to banner and “💭 Step” header. Test plan: run mini-agent and verify alignment with
long workspace paths.