Use HashMap of SkyModels instead of a single SkyModel in order to avoid a null pointer exception when more than one world is loaded at once#117
Open
Tank-Missile wants to merge 2 commits intoMinecraftModDevelopmentMods:1.12from
Conversation
a null pointer exception when more than one world is loaded at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's 1 issue currently that I have not solved, and that is when a portal is opened, the sky is default instead of the changed sky model. This is due to the sky model not being created until going through a portal.I fixed the above issue by using EntityJoinWorldEvent in StellarAPI's StellarAPINetworkManager. Hopefully this will do.