Implement coremod detection fixer, and an AT remapper#1
Draft
TheCurle wants to merge 1 commit intoMinecraftForge:masterfrom
Draft
Implement coremod detection fixer, and an AT remapper#1TheCurle wants to merge 1 commit intoMinecraftForge:masterfrom
TheCurle wants to merge 1 commit intoMinecraftForge:masterfrom
Conversation
pupnewfster
reviewed
Mar 23, 2023
| @@ -0,0 +1,286 @@ | |||
| /* | |||
| * LegacyDev | |||
| * Copyright (c) 2016-2020. | |||
There was a problem hiding this comment.
Correct me if I am wrong but I don't think this or any of the added files have the second line of the license match the change to the LICENSE-header.txt
Member
There was a problem hiding this comment.
If we're changing the header, we should just move to the simplified header like we have for the rest of the projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See RetroGradle#1 for details, but the short version:
fml.coreMods.loadto discover coremods, which used to be filled by FG2.This is now filled by LegacyDev.
FMLATproperty in the jar manifest to look for AT files. This searches for those files and adds them manually.This therefore requires aforementioned ForgeGradle extensions to be useful.
This fixes: