Fix auto-closing pairs for quotes in fstrings (bolt)#22
Open
thehuglet wants to merge 3 commits intoMinecraftCommands:mainfrom
Open
Fix auto-closing pairs for quotes in fstrings (bolt)#22thehuglet wants to merge 3 commits intoMinecraftCommands:mainfrom
thehuglet wants to merge 3 commits intoMinecraftCommands:mainfrom
Conversation
Collaborator
|
oh i missed this, seems like a good change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the extension's auto-closing pairs don't work well with bolt's fstrings, as inputting
f"orf'will not produce an auto-closing quote as expected, instead the user has to input a second quote manually, which actually produces 3 quotes (f"""orf'''). This is very annoying and requires the user to manually remove the excess quote every time.This pull requests fixes that issue, ensuring both single and double quotes auto-close correctly when used along an fstring in bolt.