Convert readme to a table of the models and labels#3
Open
ahaverty wants to merge 2 commits intoMikeLud:mainfrom
Open
Convert readme to a table of the models and labels#3ahaverty wants to merge 2 commits intoMikeLud:mainfrom
ahaverty wants to merge 2 commits intoMikeLud:mainfrom
Conversation
Author
|
Or maybe:
would be more intuitive, since 'D' might sound like "Day" to someone that missed the legend. |
|
FWIW, I'd agree with this and think it's a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@MikeLud I'm struggling to understand whether the combined model contains just light labels, or both light and dark, or whether animals has any dark models included.
So instead of annoying you in an issue, perhaps moving the readme to a table view would be nice for everyone to understand at a glance?
I've started here with my understanding of the labels, perhaps you could review/fix any issues you see?
I'm also not sure if the capitalisation differences on the IPcam-dark and license-plate Labels are intentional or not? Should everything be lowercase? (Or is it set up this way to allow people to trigger differently for dark labels?)
Easier to review in preview mode if that's not obvious.
