Merged
Conversation
Gudahtt
reviewed
Nov 22, 2023
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Member
|
I have tested this locally with the MetaMask extension e2e test suite, and it all seems to be working correctly! There was one test that failed, but it seems that the code-under-test is at fault here (the snap doing the signing is probably using a broken version of |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the release candidate for
v8.0.0.Added
wallet_watchAssetfor ERC1155 (#272)Changed
eth_signTypedData_v4example (#274)transferFromandapproveto input address for ERC20 contract (#271)