Imposter Billboard from distance#22
Open
JamesDo-vfx wants to merge 13 commits intoMaxon-Computer:mainfrom
Open
Imposter Billboard from distance#22JamesDo-vfx wants to merge 13 commits intoMaxon-Computer:mainfrom
JamesDo-vfx wants to merge 13 commits intoMaxon-Computer:mainfrom
Conversation
Contributor
|
Hello, are you the shader author? We require source files in this repository to have an open source license statement. The vast majority are using Apache 2.0, with some MIT, BSD 3 and CC BY-NC-SA. Some style points for correction:
If you have a better example image showing shader with the flipbook texture, it might be more useful to see at a glance what the shader is about. If not, someone here can cook one up. |
Updated comments to include license and copyright information.
Author
|
I am the author of the shader and I have modified the requirements you mentioned, I am not sure if it is possible to add gif images instead of images. Can you please take a look ? |
Updated author information and licensing details.
Corrected spelling of 'Impostor' in README.
Author
|
Hi, I have edited the code as best as I can based on my knowledge, can you please check if the code is up to the standard to be approved? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use Lab Imposter Texture to be able to read in redshift houdini