Skip to content

vaultsSecretsEnv no longer cancels on missing secret#918

Merged
aryanjassal merged 2 commits intostagingfrom
feature-secrets-env-egress-schema
Jul 8, 2025
Merged

vaultsSecretsEnv no longer cancels on missing secret#918
aryanjassal merged 2 commits intostagingfrom
feature-secrets-env-egress-schema

Conversation

@aryanjassal
Copy link
Contributor

@aryanjassal aryanjassal commented Jul 1, 2025 •
edited
Loading

Description

Previously, vaultsSecretsEnv used to cancel the RPC if an error was encountered, disallowing any new secrets to be obtained. This PR will instead return errors as messages, so it is upto the client to parse the message instead of an error being thrown by the RPC.

Issues Fixed

Tasks

  • 1. Make vaultsSecretsEnv continue on error/failure
  • 2. Update tests to align with behaviour change

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@aryanjassal aryanjassal self-assigned this Jul 1, 2025
tegefaulkes
tegefaulkes approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@tegefaulkes tegefaulkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, nothing stands out.

@aryanjassal aryanjassal merged commit c8e6ded into staging Jul 8, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tegefaulkes tegefaulkes tegefaulkes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aryanjassal aryanjassal

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aryanjassal @tegefaulkes