Gh 685 review2

[czarte]

Note

Clarifies blockchain service URL help text and error messaging, fixes a misattributed configurator error, and updates tests to no longer pass --blockchain-service-url where unnecessary.

• CLI/Help:
  • Update BLOCKCHAIN_SERVICE_HELP with <api-key> placeholders, improved grammar, and explicit --chain base-mainnet guidance.
• Error handling:
  • Change required-arg message to singular phrasing; fix into_configurator_error target from gas-price to blockchain-service-url.
• Unit/Integration Tests:
  • Adjust expectations for updated help/error strings.
  • Add helper to validate exceptions suppressing blockchain URL requirement.
  • Remove --blockchain-service-url from many MASQNode::start_* calls; minor arg tweaks (e.g., chain identifier from DEFAULT_CHAIN).

^{Written by Cursor Bugbot for commit 317243f. This will update automatically on new commits. Configure here.}

[cursor]

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on October 14

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: Node Startup Fails Without Blockchain URL

Removing the --blockchain-service-url parameter from MASQNode::start_standard calls in several tests causes the Node to fail startup. This parameter is required unless --fake-public-key, --crash-point, or --neighborhood-mode zero-hop is also provided, none of which were added.

node/tests/dns_resolve_failure_test.rs#L12-L15

Node/node/tests/dns_resolve_failure_test.rs

Lines 12 to 15 in 317243f

	fn dns_resolve_failure_http_response_integration() {
	let _node_to_test_against = utils::MASQNode::start_standard(
	"dns_resolve_failure_http_response_integration",
	None,

node/tests/http_through_node_test.rs#L14-L17

Node/node/tests/http_through_node_test.rs

Lines 14 to 17 in 317243f

	fn http_through_node_integration() {
	let _node = utils::MASQNode::start_standard(
	"http_through_node_integration",
	None,

node/tests/tls_through_node_test.rs#L16-L19

Node/node/tests/tls_through_node_test.rs

Lines 16 to 19 in 317243f

	fn tls_through_node_integration() {
	let _node = utils::MASQNode::start_standard(
	"tls_through_node_integration",
	None,

node/tests/initialization_test.rs#L269-L280

Node/node/tests/initialization_test.rs

Lines 269 to 280 in 317243f

	#[test]
	fn node_creates_log_file_with_heading_integration() {
	let config = CommandConfig::new()
	.pair("--neighborhood-mode", "standard")
	.pair("--ip", "1.0.0.1")
	.pair(
	"--neighbors",
	&format!(
	"masq://{}:UJNoZW5p_PDVqEjpr3b-8jZ_93yPG8i5dOAgE1bhK-A@12.23.34.45:5678",
	DEFAULT_CHAIN.rec().literal_identifier
	),
	);

node/tests/dns_resolve_failure_test.rs#L35-L38

Node/node/tests/dns_resolve_failure_test.rs

Lines 35 to 38 in 317243f

	fn dns_resolve_failure_tls_response_integration() {
	let _node_to_test_against = utils::MASQNode::start_standard(
	"dns_resolve_failure_tls_response_integration",
	None,

node/tests/connection_shutdown_test.rs#L23-L24

Node/node/tests/connection_shutdown_test.rs

Lines 23 to 24 in 317243f

	"proxy_client_stream_reader_dies_when_client_stream_is_killed_integration",
	Some(CommandConfig::new().pair("--ui-port", &ui_port.to_string())),

node/tests/dump_configuration_test.rs#L23-L24

Node/node/tests/dump_configuration_test.rs

Lines 23 to 24 in 317243f

	CommandConfig::new()
	.pair("--ui-port", &port.to_string())

node/tests/financials_test.rs#L75-L76

Node/node/tests/financials_test.rs

Lines 75 to 76 in 317243f

	test_name,
	Some(CommandConfig::new().pair("--ui-port", &port.to_string())),

node/tests/initialization_test.rs#L158-L160

Node/node/tests/initialization_test.rs

Lines 158 to 160 in 317243f

	Some(
	CommandConfig::new()
	.pair(

node/tests/initialization_test.rs#L225-L227

Node/node/tests/initialization_test.rs

Lines 225 to 227 in 317243f

	Some(
	CommandConfig::new()
	.pair("--ui-port", &port.to_string())

node/tests/node_exits_from_future_panic_test.rs#L69-L70

Node/node/tests/node_exits_from_future_panic_test.rs

Lines 69 to 70 in 317243f

	"node_logfile_does_not_belong_to_root_integration",
	Some(CommandConfig::new().pair("--chain", "polygon-amoy")),

node/tests/ui_gateway_test.rs#L30-L32

Node/node/tests/ui_gateway_test.rs

Lines 30 to 32 in 317243f

	Some(
	CommandConfig::new()
	.pair("--ui-port", &port.to_string())

node/tests/ui_gateway_test.rs#L64-L66

Node/node/tests/ui_gateway_test.rs

Lines 64 to 66 in 317243f

	Some(
	CommandConfig::new()
	.pair("--ui-port", &port.to_string())

node/tests/ui_gateway_test.rs#L209-L211

Node/node/tests/ui_gateway_test.rs

Lines 209 to 211 in 317243f

	Some(
	CommandConfig::new()
	.pair("--chain", DEFAULT_CHAIN.rec().literal_identifier)

 

---

[dnwiebe]

Meaningless approval, but it looks good except for a couple of minor nitpicks.