Conversation
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
czarte
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Introduces a new startup flag that changes how the node’s persisted public key/identity is selected and stored, including new failure paths when the old key can’t be recovered. While scoped, it touches bootstrapping/config parsing and key persistence logic.
Overview
Adds a new
--new-public-key {on|off}configuration option (CLI/config file/env) to control whether the node reuses the previously stored public key or forces generation/persistence of a new one on startup, with explicit startup failures whenoffis requested but no prior key (or no--db-password) is available.Standardizes
on/offparsing via a sharedOnOffenum (reused by--scans), threads the new flag throughBootstrapperConfig/setup reporting, and expands unit tests around key selection and config presentation.Updates multinode integration tests to use
www.testingmcafeesites.com(and more specific content assertions), improves bookkeeping mismatch diagnostics, adds environment isolation in config dumper tests, and ignores JetBrains Copilot files in.gitignore.Written by Cursor Bugbot for commit 7985416. This will update automatically on new commits. Configure here.