fixed c# dictionary deseriead failed, the string key can't convert to…#118
Open
jiangdengc wants to merge 1 commit intoLitJSON:developfrom
Open
fixed c# dictionary deseriead failed, the string key can't convert to…#118jiangdengc wants to merge 1 commit intoLitJSON:developfrom
jiangdengc wants to merge 1 commit intoLitJSON:developfrom
Conversation
devlead
requested changes
Jun 24, 2020
Member
devlead
left a comment
devlead
left a comment
There was a problem hiding this comment.
There seems to be failing tests after this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because of that the all dictionary key has been convert to string , there is an issue which string key can't convert to correct key type of dictionary when deseriead from json, so i fixed it for my use, maybe there is some mistake . you can modify