strncpy -> rtapi_strlcpy for string termination#2683
Merged
andypugh merged 1 commit intoLinuxCNC:2.9from Jul 7, 2024
Merged
Conversation
Collaborator
|
"libnml/buffer/shmem.cc:318:10: error: ‘rtapi_strlcpy’ was not declared in this scope" Missing include file? |
Collaborator
|
linuxcnc stuttgart meeting (norbert not to blame) says merge when CI passes. eventually convert to std::string. |
Collaborator
|
The std::string proposal came up in #1922 too. How can we decide if we want to move towards std::string or not? |
Collaborator
Author
|
Some tests are failing: Let's see if that also happens for other PRs or if I have indeed messed something up. |
Moved #incl of rtapi_string outside extern C Remove request for consts Added FIXME about memory leak and fixed whitespace issue (Petter) Rebased by Petter Reinhodltsen on top of current 2.9.
54c7b8c to
3a03a10
Compare
Collaborator
|
I rebased the change on top of the 2.9 branch, and did some minor
cleanup.
…--
Happy hacking
Petter Reinholdtsen
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stuttgart LinuxCNC attempt to address compiler warnings.
Using rtapi_strlcpy to always have 0-terminated strings.