Activation Phase 3: ActivationInput resolver seam#26
Merged
LegendaryForge merged 2 commits intomainfrom Jan 31, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces an Activation Phase 3 scaffold that allows server-side resolved activation attributes to reach gates, without changing Phase 2 behavior or invariants.
Changes
ActivationInputAPI for server-resolved activation data (gate key, attributes, optional targetRef).ActivationInputResolverAPI as a server-side seam for resolving authoritative activation inputs.DefaultActivationServiceto resolveActivationInputand pass resolved attributes intoConditionGaterequests (no longer hardcoded empty).DefaultCoreRuntimewith a default resolver (empty attributes, targetRef passthrough) and injected it intoDefaultActivationService.ActivationService.ActivationAttemptRequestwith optionaltargetRef.Rationale
Phase 2 validated activation contracts and invariants but always evaluated gates with empty attributes, causing content-side activation gates (e.g., quest-step checks) to deny by default. This change introduces a minimal, server-side resolver seam so content mods can supply authoritative activation attributes without pushing quest or world logic into Core.
Verification
./gradlew spotlessApply clean test