Conditionalize option 'Fail import for undefined visits' during folder import#6607
Open
labkey-bpatel wants to merge 1 commit intodevelopfrom
Open
Conditionalize option 'Fail import for undefined visits' during folder import#6607labkey-bpatel wants to merge 1 commit intodevelopfrom
labkey-bpatel wants to merge 1 commit intodevelopfrom
Conversation
…r import via Folder Management.
labkey-adam
reviewed
Apr 28, 2025
Contributor
labkey-adam
left a comment
There was a problem hiding this comment.
@labkey-bpatel I'd like to discuss before reviewing and your merging this PR. Since any folder archive could create a study in a currently non-study folder (and also define visits), it's not clear to me the conditions under which we would suppress this checkbox. I'm also not clear the intent reading the code. Maybe best to chat about this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The 'Fail import for undefined visits' option is displayed by default on the folder import page in Folder Management, regardless of whether the import is for a Study or a non-Study folder. It's a no-op for non-Study, however, annoying to see. This change was introduced as part of the 'Deprecate advanced import options' - see Related PR.
Related Pull Requests
Changes