use java 11 instead of java 9 + basic compilation #250
Conversation
changed reference to ComprehensiveZmanimCalendar instead of non-existing ComplexZmanimCalendar stubbed missing methods to ComprehensiveZmanimCalendar
changed reference to ComprehensiveZmanimCalendar instead of non-existing ComplexZmanimCalendar stubbed missing methods to ComprehensiveZmanimCalendar
|
|
||
| public Date getSofZmanTfilaFixedLocal() { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
These were intended for removal. They had forRemoval=true. We should not add them back in
There was a problem hiding this comment.
I added these methods in order to allow the test to compile, there were referenced to all these methods...
| public Date getBainHasmashosYereim2Point1Degrees() { | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
All of the methods above were spelled Hasmasos. There was already renamed Hashmashos (adding the H back in). If test cases broke for these, we should tweak the spelling to the version with an H.
|
|
||
| public Date getSofZmanTfilahAteretTorah() { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
@elijulian , The above three were intended for removal as per the deprecation warning.
| import java.io.BufferedWriter; | ||
| import java.io.File; | ||
| import java.io.FileWriter; | ||
| import java.io.IOException; |
There was a problem hiding this comment.
@elijulian , were these imports really used? Was this due to the JDK update?
Part of PR #250 Thanks @elijulian
2 participants
changed reference to ComprehensiveZmanimCalendar instead of non-existing ComplexZmanimCalendar stubbed missing methods to ComprehensiveZmanimCalendar