add pipeline vs shader objects to the deprecated chapter#348
Open
gpx1000 wants to merge 1 commit intoKhronosGroup:mainfrom
Open
add pipeline vs shader objects to the deprecated chapter#348gpx1000 wants to merge 1 commit intoKhronosGroup:mainfrom
gpx1000 wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
Contributor
|
Hi @daniel-story, can you take a quick look at this Guide chapter covering deprecation re: Shader Objects and let us know if you have feedback? @pdaniell-nv, feel free to review/comment as well. Thanks! |
|
|
||
| To support both approaches: | ||
|
|
||
| 1. Detect `VK_EXT_shader_object` support and enable the feature at device creation time. |
There was a problem hiding this comment.
I would prefer that this instead recommends writing only shader object code and relying on the extension layer to take care of the fallback to pipelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per F2F request, first draft on updating for shader objects.
-- might want to iterate on the language a bit to ensure that it's very clear that pipelines aren't deprecated. Any suggestions are very welcomed.