Adapt build to new cibuildwheel and other upstream changes#314
Merged
hendrikmuhs merged 8 commits intoKeyviDev:masterfrom Nov 6, 2024
Merged
Adapt build to new cibuildwheel and other upstream changes#314hendrikmuhs merged 8 commits intoKeyviDev:masterfrom
hendrikmuhs merged 8 commits intoKeyviDev:masterfrom
Conversation
Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 2.17.0 to 2.21.3. - [Release notes](https://github.com/pypa/cibuildwheel/releases) - [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md) - [Commits](pypa/cibuildwheel@v2.17.0...v2.21.3) --- updated-dependencies: - dependency-name: pypa/cibuildwheel dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
hendrikmuhs
changed the title
Merged
hendrikmuhs
added a commit
that referenced
this pull request
Aug 7, 2025
after updating boost in #314, this PR fixes some issues: - newer versions of boost require linking the process library, see Compiling Boost.Process as header-only fails boostorg/process#390 - older versions don't ship boost process and the upcoming 1.89 might go back to header-only - fix linking on macos for newer boost and remove pinning 1.85 - reason: upstream brew package removed boost_thread-mt, now there is only boost_thread (-mt is now default), same as on Linux - Mac users that compile from source need to update boost - fix cmake deprecation warning - only applies to very old boost versions which aren't supported anyway, raised the minimum required versions to 1.80 for boost process v2 - update ubuntu version for rust workflow to get newer boost there - rust bindings don't support keyvi index, that's why the newer boost wasn't necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes builds using the latest cibuildwheel. Due to incompatible changes introduced upstream pypy(pypa/distutils#283) had to be taken out for now.
In the long run we should switch away from setuptools, so these changes are just considered temporary until #310 is ready.