Conversation
|
@dependabot rebase |
c13cb1b to
b95a3ac
Compare
|
@dependabot rebase |
Bumps [lukka/run-cmake](https://github.com/lukka/run-cmake) from 3 to 10. - [Release notes](https://github.com/lukka/run-cmake/releases) - [Commits](lukka/run-cmake@v3...v10) --- updated-dependencies: - dependency-name: lukka/run-cmake dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
b95a3ac to
6b6788c
Compare
|
The error we get is: And it is related to update to the 10th version. https://github.com/lukka/run-cmake?tab=readme-ov-file#run-cmakev10-runs-cmake-with-cmakepresetsjson Honestly don't really know what presets are, but that is the missing thing here. |
|
It asks us to commit a json file like this: https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html#id4 It seems this is where cmake is heading towards. However it seems to require a larger refactoring/overhaul of the whole cmake configs. I don't know how urgent this is, but github wants to get rid of node16 based actions and we are using a super old version of this action. We might realize one day that it suddenly stops working. It makes sense to do something about it. Note, we have several options, e.g. it might be easier to jump to a reasonable recent version of this action before the introduction of this mandatory preset file( |
|
Yeah, no strong opinion whether to use action, or run cmake ourself. |
Bumps lukka/run-cmake from 3 to 10.
Release notes
Sourced from lukka/run-cmake's releases.
Commits
2ce8982fix spacing in contributing.md1f075d1- drop gulp.2f041fdBump@babel/traversefrom 7.11.5 to 7.23.2a65e42aBump actions/checkout from 3 to 4f73dfdfadd codeql validation93b0f6cBump actions/checkout from 3 to 4fbcfe00Bump word-wrap from 1.2.3 to 1.2.4f9520b0Bump semver from 5.7.1 to 5.7.2c6e1f27Bump tough-cookie from 4.1.2 to 4.1.3c2b72afreword the README.md regarding VCPKG_ROOT env var.You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)