add lane detect with control of vehicle cutting and smoothed display#104
Open
Tirtza-L wants to merge 2 commits intoimg_processing_mainfrom
Open
add lane detect with control of vehicle cutting and smoothed display#104Tirtza-L wants to merge 2 commits intoimg_processing_mainfrom
Tirtza-L wants to merge 2 commits intoimg_processing_mainfrom
Conversation
ChedvaErblich
requested changes
Oct 8, 2024
Collaborator
ChedvaErblich
left a comment
ChedvaErblich
left a comment
There was a problem hiding this comment.
A few general comments:
- Please make sure not to write commit titles that are too long.
The title should be short, and if there is additional content, it should be placed in the body of the message.
There should be a blank line between the title and the body, otherwise, everything will be included as the title. - Please have someone else review the code, and after she approves it, I'll push it in.
img_processing/include/regression.h
Outdated
| { | ||
| X sum; | ||
| std::vector<T> temp; | ||
| for (int i = 0; i < A.size(); i++) |
Collaborator
There was a problem hiding this comment.
On for the closing bracket should start the loop line
| return linesP; | ||
| } | ||
|
|
||
| bool LaneDetector::drawLanes(std::vector<Vec4i> lines) |
Collaborator
There was a problem hiding this comment.
you should base your commit on the SHOW_FRAMES flag that will be added soon to main
img_processing/src/manager.cpp
Outdated
| int Manager::processing(const Mat &newFrame, bool isTravel) | ||
| { | ||
| // Start measuring time | ||
| auto start = high_resolution_clock::now(); |
Collaborator
There was a problem hiding this comment.
Is it for your tests?
I don't think it's part of your comment, right?
|
|
||
| laneDetector.init(); | ||
|
|
||
| while(true) |
Collaborator
There was a problem hiding this comment.
On while the closing bracket should start the loop line
|
|
||
| laneDetector.manageLaneDetector(sharedFrame); | ||
| laneDetector.drawLanesOnImage(sharedFrame); | ||
|
|
Collaborator
There was a problem hiding this comment.
Remove this blank line
img_processing/src/manager.cpp
Outdated
| longTime = duration.count(); | ||
| } | ||
| if(duration.count() < longTime){ | ||
| int key1 = waitKey( longTime - duration.count()); |
Collaborator
There was a problem hiding this comment.
It's better to have a separate commit for this change
Tirtza-L
force-pushed
the
img_processing/add-lane-detection
branch
5 times, most recently
from
59905e4 to
82c2891
Compare
TziporaGoldshmidt
force-pushed
the
img_processing/add-lane-detection
branch
from
82c2891 to
59905e4
Compare
TziporaGoldshmidt
force-pushed
the
img_processing/add-lane-detection
branch
from
59905e4 to
1abbbb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.