Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered by nesrak1, from discussion on the the Discord: https://discord.com/channels/603359898507673630/1407381658151292988/1468551292400959598
Unity requires the written objects to be sorted by
path_idsequentially.Newer Unity versions seem to work with a scrambled order, but older versions like
2018.4.2f1will refuse to load objects that are written out of order.Since dictionaries in python maintain insertion order, if a new object is added to the dictionary, it will be appended to the very end, meaning any freshly inserted objects with a new
path_idwill not load correctly in older Unity versions.I'm not sure about the performance impact here with larger bundle files, if it does become an issue there might be ways to ensure the correct order on insertion (not sure if a dictionary is the correct backing structure for that though.)